← 输入框|bugs.python.org|刷新

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
标题: Missing dependency on Include/cpython/frameobject.h
类型: compile error Stage: resolved
Components: Build Versions: Python 3.10
process
状态: closed Resolution: fixed
Dependencies: 后续:
分配给: 抄送列表: gvanrossum, miss-islington, skip.montanaro, vstinner
优先级: normal 关键字: patch

Created on 2020-08-04 14:23 by skip.montanaro, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 21732 closed skip.montanaro, 2020-08-04 14:25
PR 22999 merged vstinner, 2020-10-27 02:15
PR 23000 merged miss-islington, 2020-10-27 03:41
Messages (12)
msg374809 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) 日期: 2020-08-04 14:23
When Include/cpython/frameobject.h was created, there was no dependency added to Makefile.pre.in.
msg374810 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) 日期: 2020-08-04 14:26
Created a pull request. Hopefully I didn't muff the protocol too badly.
msg374811 - (view) Author: STINNER Victor (vstinner) * (Python committer) 日期: 2020-08-04 14:28
> Created a pull request. Hopefully I didn't muff the protocol too badly.

Your PR has 124 commits, that looks strange.
msg374812 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) 日期: 2020-08-04 14:30
> Your PR has 124 commits, that looks strange.

Funny, it told me just one file had changed (Makefile.pre.in). I was attempting to make a PR against that one change from my fork of master to the main repo. Let me take another crack at it.
msg374813 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) 日期: 2020-08-04 14:35
I see what @vstinner is talking about. If you look at those commit messages, they all look to be of the form "Merge remote-tracking branch 'upstream/master'". That is, they are me syncing python/cpython/master to python/smontanaro/master. There is, in fact, just the one file changed, Makefile.pre.in, with the addition of a single dependency.

I don't know how to get rid of all those commit messages.
msg374815 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) 日期: 2020-08-04 14:38
> they all look to be of the form "Merge remote-tracking branch 'upstream/master'".

Aside from one where I erroneously committed a change to the wrong
branch, then backed it out immediately.
msg374816 - (view) Author: STINNER Victor (vstinner) * (Python committer) 日期: 2020-08-04 14:48
> I don't know how to get rid of all those commit messages.

I suggest you to create a local branch per change, rather than using "master".

I consider that "origin" is git@github.com:python/cpython.git. Check your remotes with "git remote -v".

Example where "master" is your PR 21732.

git switch -c frameobject master
git switch master
git reset --hard origin/master  # revert your changes

Then fix your frameobject:

git switch master
git fetch && git merge --ff  # ensure that you are up to date
git switch frameobject
git rebase master

Check what you get:

git log master.. --pretty=oneline

You should see only one commit.

Close your PR and create a new one on the "frameobject" branch.
msg374817 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) 日期: 2020-08-04 14:58
> > I don't know how to get rid of all those commit messages.
>
> I suggest you to create a local branch per change, rather than using "master".
>
> I consider that "origin" is git@github.com:python/cpython.git. Check your remotes with "git remote -v".

Hmmm... Seems like a bunch of extra work for a one-line change to a
Makefile... There's no easier way to create PRs for these trivial
changes?
msg375026 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) 日期: 2020-08-08 00:44
Sorry to rain on your parade, but couldn’t this be a new package on PyPI?
msg375027 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) 日期: 2020-08-08 00:47
Wrong issue, sorry. (Bpo bug?)
msg379729 - (view) Author: STINNER Victor (vstinner) * (Python committer) 日期: 2020-10-27 03:41
New changeset a6879d9445f98833c4e300e187956e2a218a2315 by Victor Stinner in branch 'master':
bpo-41474, Makefile: Add dependency on cpython/frameobject.h (GH-22999)
https://github.com/python/cpython/commit/a6879d9445f98833c4e300e187956e2a218a2315
msg379731 - (view) Author: miss-islington (miss-islington) 日期: 2020-10-27 04:02
New changeset 562ad7624e5fe22fdded9b39723c562255a49abd by Miss Skeleton (bot) in branch '3.9':
bpo-41474, Makefile: Add dependency on cpython/frameobject.h (GH-22999)
https://github.com/python/cpython/commit/562ad7624e5fe22fdded9b39723c562255a49abd
历史
日期 用户 动作 参数
2022-04-11 14:59:34admin修改github: 85646
2020-10-27 04:02:03miss-islington修改消息: + msg379731
2020-10-27 03:42:46vstinner修改状态: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-10-27 03:41:53miss-islington修改抄送: + miss-islington
pull_requests: + pull_request21915
2020-10-27 03:41:37vstinner修改消息: + msg379729
2020-10-27 02:15:58vstinner修改stage: patch review
pull_requests: + pull_request21914
2020-08-08 00:47:02gvanrossum修改消息: + msg375027
2020-08-08 00:44:32gvanrossum修改抄送: + gvanrossum
消息: + msg375026
2020-08-04 14:58:01skip.montanaro修改消息: + msg374817
2020-08-04 14:48:03vstinner修改消息: + msg374816
2020-08-04 14:38:35skip.montanaro修改消息: + msg374815
2020-08-04 14:35:23skip.montanaro修改消息: + msg374813
2020-08-04 14:30:54skip.montanaro修改消息: + msg374812
2020-08-04 14:28:12vstinner修改抄送: + vstinner
消息: + msg374811
2020-08-04 14:26:29skip.montanaro修改消息: + msg374810
stage: patch review -> (no value)
2020-08-04 14:25:41skip.montanaro修改keywords: + patch
stage: patch review
pull_requests: + pull_request20877
2020-08-04 14:23:53skip.montanaro创建