Repository navigation
Pass the HAVING context to ALL / ANY / SOME subqueries to close #2855 - #2920
Merged
Merged
Conversation
Member
|
Short and precise. Love it. Than you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2855
Problem
HAVING ... > ALL (subquery)threwReferenceError: p is not defined, as didANYandSOME:The same comparison in
WHEREworks.Cause
In
src/50expression.js, the code forx op ALL (subquery)andx op ANY|SOME (subquery)always called the subquery with a variable namedp.pis the row variable inWHERE, butHAVINGcompiles withg, sopis undefined there.INandNOT INalready pass${context}, which is why they work inHAVING.Fix
The ALL and ANY/SOME branches pass
${context}, the same asIN. InWHEREthe context is stillp, so the generated code there doesn't change.Tests
New
test/test2855.js:a > ALL (...)inHAVING> ANYand= SOMEinHAVINGALLandANYinWHERE, which should give the same results as beforeResults:
src/, the twoHAVINGtests fail withReferenceError: p is not defined.bun test --preload ./test/bun-setup.js ./test/test2855.js→ 3 passed.developon my Windows machine.