Repository navigation
Conversation
atriolo
commented
Nov 4, 2026
Contributor
- The noise is now configured as a rate in hits/pixel/s and converted to hits per ROF using the ROF length of each layer. This keeps the noise level independent of the ROF length. The default is 0.2 hits/pixel/s for both TRK and FT3, which corresponds to ~1e-7 hits/pixel/ROF with 18-BC ROFs (default used until now)
- Now it can be passed as configKeyValue as before, but the value to be passed should be 0.2 (or similar values) to simulate a correct amount of noise, instead of the old 1e-7. The definitive noise value is still to be decided, though.
- The ToA of noise digits is now generated uniformly within the ROF instead of being 0 as it was in the first draft
…ts/px/ROF + uniform ToA within ROF for noise digits
atriolo
requested review from
fcolamar,
mconcas,
njacazio,
sawenzel and
shahor02
as code owners
November 4, 2026 21:29
njacazio
approved these changes
Nov 5, 2026
njacazio
enabled auto-merge (squash)
November 5, 2026 04:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.