toLocaleString() doesn't localise the number #8249

Activity

1. NickIliev commented on Jan 15, 2020

   

   NickIliev

   on Jan 15, 2020

   Contributor

   More actions

   NativeScript uses JavaScriptCore VM (for Android) which has a known issue with toLocalString. So that said, there is not much that can be done on the NativeScript side.. you could look for a custom formatter to handle this case.

   👎React with 👎1Reacted by Nikkolai Fernandez
2. NickIliev

   added

   os: android

   on Jan 15, 2020
3. Znegl commented on Jan 15, 2020

   

   Znegl

   on Jan 15, 2020

   Author

   More actions

   That's sad :'( (not that your'e using a third party, but that they have issues)...

   I'm experiencing the bug on iOS too — is it the same JS core?
4. NickIliev commented on Jan 15, 2020

   

   NickIliev

   on Jan 15, 2020

   Contributor

   More actions

   Not sure if the issue on iOS is the same (the VM is V8 so - no, this is a different VM). Byt the way the VMs are not a third-party library (like a plugin) but the core engines that are handling the runtimes. So the same issue is present in react-native (as they are also using JavaScriptCore for Android).

   👍React with 👍1Reacted by Thomas Grinderslev
5. NickIliev

   closed this as completedon Jan 15, 2020
6. keithgulbro commented on Apr 13, 2020

   

   keithgulbro

   on Apr 13, 2020

   More actions

   Here's a temporary workaround, obviously not the best solution but it works in Nativescript-Vue:

        var sampleNumber = 123456789;
   
         return (
           "$" +
             sampleNumber
             .toString()
             .split("")
             .reverse()
             .map((number, index, array) => {
               return (index + 1) % 3 === 0 && array[index + 1]
                 ? `,${number}`
                 : number;
             })
             .reverse()
             .join("")
   

   👍React with 👍1Reacted by Patrick Lohan
7. andresilva-cc commented on May 26, 2020

   

   andresilva-cc

   on May 26, 2020

   Last edited by andresilva-cc

   More actions

   Here's a temporary workaround, obviously not the best solution but it works in Nativescript-Vue:

        var sampleNumber = 123456789;
   
         return (
           "$" +
             sampleNumber
             .toString()
             .split("")
             .reverse()
             .map((number, index, array) => {
               return (index + 1) % 3 === 0 && array[index + 1]
                 ? `,${number}`
                 : number;
             })
             .reverse()
             .join("")
   

   This almost works, the only problem is that we lose the decimal part (example: 1000.00 turns into $ 1,000)
   EDIT: Fixed it:

   function format(value) {
     const decimalPart = value.toFixed(2).split('.')[1]
     return (
       '$ ' +
         value
         .toString()
         .split('.')[0]
         .split('')
         .reverse()
         .map((number, index, array) => {
           return (index + 1) % 3 === 0 && array[index + 1]
             ? `,${number}`
             : number;
         })
         .reverse()
         .join('')
         + '.' + decimalPart
     )
   }