Repository navigation
fix(core): prevent goBack from removing topmost frame from stack - #11437
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit cec77ba
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
CatchABus
marked this pull request as draft
September 16, 2026 15:12
CatchABus
marked this pull request as ready for review
September 19, 2026 21:29
CatchABus
marked this pull request as draft
September 19, 2026 21:31
CatchABus
marked this pull request as ready for review
September 20, 2026 18:19
CatchABus
requested review from
NathanWalker and
farfromrefug
and
a lite review from Copilot
and removed request for
Copilot
September 20, 2026 18:20
farfromrefug
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
In android 12 and later, root launcher activities are no longer finished on Back press.
However, {N} core overrides backpress and removes frames from stack at times, thinking that the activity will finish.
Then, user attempts to launch the app and it will simply resume without recreating views and frames will still be missing from the stack.
That results in Frame
topmost()andgetFrameById()returning a wrong frame instance in apps with multiple frames.What is the new behavior?
This PR gets rid of a redundant frame stack pop handling that is around since the early days of NativeScript (see cc829e0).
Back then, core didn't have support for native view disposal which is what removes frames from stack nowadays.
See: https://github.com/NativeScript/NativeScript/blob/main/packages/core/ui/frame/index.android.ts#L546
https://github.com/NativeScript/NativeScript/blob/main/packages/core/ui/frame/index.ios.ts#L76
As a result, the frame helper functions will return the proper
Frameview instance.The PR also removes an unneeded override of
_popFromFrameStack.Fixes/Closes #11436.