Repository navigation
fix(vite): resolve a file before a same-named directory - #11464
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit a63c607
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
triniwiz
force-pushed
the
fix/vite-resolve-file-before-directory
branch
from
September 28, 2026 04:56
977256b to
f664460
Compare
The resolver plugins looped extensions outermost, so platform.js next to platform/index.ios.ts still resolved to the directory on the .ts pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
resolveNativeScriptPlatformFilechecks a directory barrel (base/index.<platform>.ext) before the plain file (base.ext). When a package ships bothplatform.jsand aplatform/directory,import './platform'resolves to the directory instead of the file, unlike Node and webpack.What is the new behavior?
Files come before directories, as in Node and webpack:
base.<platform>.ext, thenbase.ext, thenbase/index.<platform>.ext. esbuild, which builds the deps bundle, already tries extensions before directories, so only this helper changes.Tests:
packages/vite/helpers/utils.spec.ts(4) covers file-over-directory, platform file over plain file, the directory barrel fallback and no match. The first case fails without the fix.