Repository navigation
fix(vite): Android release bundles keep the class names the binding generator reads - #11516
Merged
Merged
Conversation
…enerator reads
The Android static binding generator reads the name in `extend('name', {...})`
and `JavaProxy('name')` only from a quoted string, and finds a decorated class
only from its own `X = __decorate([JavaProxy('name')], X)` statement. Minified
release output broke both: Oxc prints every string as a template literal, and
compression folds those statements into comma sequences. NativeScriptActivity,
FragmentClass, OnBackPressedCallback and the lifecycle and component callbacks
were then left out of the APK and generated by the runtime at launch, which
works only where dex injection into the app class loader succeeds.
Android release builds now compress without sequences, and a final pass
requotes the names of substitution-free `extend`/`JavaProxy` template literals
(same length, so source maps stay valid). Compression and mangling stay on;
bundles grow about 5%. Workers get the same treatment.
|
View your CI Pipeline Execution ↗ for commit 1ab23d1
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android static binding generator reads the name in
extend('name', {...})andJavaProxy('name')only from a quoted string, and finds a decorated class only from its ownX = __decorate([JavaProxy('name')], X)statement. Minified release output broke both: Oxc prints every string as a template literal, and compression folds those statements into comma sequences. NativeScriptActivity, FragmentClass, OnBackPressedCallback and the lifecycle and component callbacks were then left out of the APK and generated by the runtime at launch, which works only where dex injection into the app class loader succeeds.Android release builds now compress without sequences, and a final pass requotes the names of substitution-free
extend/JavaProxytemplate literals (same length, so source maps stay valid). Compression and mangling stay on; bundles grow about 5%. Workers get the same treatment.