Repository navigation
Conversation
…o the view's own values
Core played the first keyframe as a jump and held the last one, so
keyframes that leave out an end did not animate as in CSS:
`to { transform: rotate(360deg) }` jumped to 360deg on every iteration
and a spinner never turned, and keyframes that stop at 50% never came
back.
A missing 0% or 100% keyframe is now added when the animation is built,
and filled with the view's own values for the animated properties when
it plays. An auto width or height, which cannot be animated from, is
left out.
|
View your CI Pipeline Execution ↗ for commit 4f32aca
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
A keyframe animation plays its first keyframe as a jump and holds its last one. When the keyframes leave out
0%or100%, the animation does not behave as in CSS, where the element's own values fill the missing ends:@keyframes spin { to { transform: rotate(360deg) } }jumps to 360° on every iteration, so the spinner never turns (Bootstrap'sspinner-border, Tailwind'sanimate-spin).50%never come back (Bootstrap'sspinner-grow).What is the new behavior?
KeyframeAnimation.keyframeAnimationFromInfo()adds the missing0%/100%keyframe, andplay()fills it with the view's own values for the properties the other keyframes animate (rotate, scale, translate, opacity, background color, width, height). Anautowidth or height, which cannot be animated from, is left out. TheKeyframeAnimationInfopassed in is not modified.Tests:
ui/animation/keyframe-animation.spec.ts(6).Verified with all of these core PRs merged together (#11527–#11537):
apps/automatedpasses on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependentIMAGE-CACHE.test_ImageCache_ValidUrltimeout, which also passes on reruns).