Repository navigation
feat(core): rem lengths - #11533
Open
triniwiz wants to merge 2 commits into
Open
feat(core): rem lengths#11533triniwiz wants to merge 2 commits into
triniwiz wants to merge 2 commits into
Conversation
Core's length and font-size converters read `1.5rem` with parseFloat, as 1.5 device-independent pixels, so text styled `font-size: 1rem` (every CSS framework's body text) came out 1 dip tall and rem margins and paddings collapsed. A rem length is now a multiple of the root font size, 16 by default as on the web, in lengths, percent lengths, `font-size` and the `font` shorthand. `Length.setRootFontSize()` changes it for values parsed afterwards, so a layout library with its own root font size can keep the two in step.
|
View your CI Pipeline Execution ↗ for commit da41177
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Core's length and font-size converters read
1.5remwithparseFloat, as 1.5 device-independent pixels. Text styledfont-size: 1rem(every CSS framework's body text) is 1 dip tall, and rem margins, paddings and sizes collapse.What is the new behavior?
Length,FixedLength,PercentLength,font-sizeand thefontshorthand.Length.setRootFontSize()/Length.getRootFontSize()change and read it for values parsed afterwards, so a layout library with its own root font size (MasonKit has one) can keep the two in step.emis unchanged: it needs the element's font size, which these converters do not have.Tests:
ui/styling/length-rem.spec.ts(7).Verified with all of these core PRs merged together (#11527–#11537):
apps/automatedpasses on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependentIMAGE-CACHE.test_ImageCache_ValidUrltimeout, which also passes on reruns).