Repository navigation
Conversation
|
View your CI Pipeline Execution ↗ for commit c6b7b73
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
Animations were built once per rule from its raw declarations, before any variable was resolved, so `animation: var(--animate-spin)` (how Tailwind's `animate-*` utilities are written) and `animation-duration: var(--speed)` never played. A `var()` inside `@keyframes` failed to convert and the exception stopped the rest of the stylesheet being applied. A rule whose animation declarations use variables, and keyframes whose values use them, are now resolved against each view when its animations play. Everything else is still parsed once. Keyframes that cannot be converted are skipped with a trace warning instead of throwing.
triniwiz
force-pushed
the
fix/css-animation-variables
branch
from
October 15, 2026 13:16
20397b6 to
be09a7d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
animation: var(--animate-spin)(how Tailwind'sanimate-*utilities are written) andanimation-duration: var(--speed)never play.var()inside@keyframesfails to convert, and the exception stops the rest of the stylesheet from being applied.What is the new behavior?
Tests:
ui/styling/css-animation-variables.spec.ts(5); four fail without the change.Verified with all of these core PRs merged together (#11527–#11537):
apps/automatedpasses on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependentIMAGE-CACHE.test_ImageCache_ValidUrltimeout, which also passes on reruns).