Repository navigation
Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test apps-automated -c=android |
❌ Failed | 20m 27s | View ↗ |
nx run-many --target=test --configuration=ci --... |
✅ Succeeded | <1s | View ↗ |
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.
☁️ Nx Cloud last updated this comment at 2026-10-15 21:02:26 UTC
commit: |
Renderers such as React and DOMiNATIVE swap an event handler by removing the old listener and adding the new one, which for an inline arrow happens on every render, often in response to the gesture itself. Each gesture listener owned its own GesturesObserver, so removing it tore down the native recognizer (the UIGestureRecognizer on iOS, the gesture detector on Android) and adding the new one created a fresh recognizer that had never seen the touch in progress. A handler that set state on `down` got no `move` or `up` after it, so sliders and charts only ever saw the first event; pan, pinch and the other detectors lost the gesture the same way. Removing a gesture listener now stops calling it at once but keeps its observer, and the native recognizer, until the next turn. A listener for the same gesture added before then takes over that observer instead of creating a new one, so it receives the rest of the gesture. Observers that are not taken over are disconnected in the next turn as before.
triniwiz
force-pushed
the
fix/ios-gesture-listener-churn
branch
from
October 15, 2026 13:16
23fecd1 to
8c50e25
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Renderers such as React and DOMiNATIVE swap an event handler by removing the old listener and adding the new one, which for an inline arrow function happens on every render, often in response to the gesture itself. Each gesture listener owns its own
GesturesObserver, so removing it tears down the native recognizer (theUIGestureRecognizeron iOS, the gesture detector on Android), and adding the new one creates a recognizer that never saw the touch in progress. A handler that sets state ondowngets nomoveorupafter it, so sliders and charts only ever see the first event. Pan, pinch and the other gestures lose the gesture the same way.What is the new behavior?
GesturesObserverBase._setCallback, internal) instead of creating a new one, so it receives the rest of the gesture.getGestureObservers()reflects a removal immediately.UIGestureRecognizerImpl.recognize()calls the owner's current callback with the owner's current context.Tests:
ui/core/view/gesture-observers.spec.ts(6): the recognizer is kept across a swap, the new listener receives the in-progress gesture with the rightthis, a removed listener is silent immediately, an unused recognizer is removed in the next turn, observers are not reused across gesture types.apps/automatedgainstest_swapping_touch_listener_keeps_native_recognizer(iOS) andtest_swapping_gesture_listener_reuses_observer.Verified with all of these core PRs merged together (#11527–#11537):
apps/automatedpasses on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependentIMAGE-CACHE.test_ImageCache_ValidUrltimeout, which also passes on reruns).