Repository navigation
fix(vite): keep value: undefined in HMR-served Vue scripts - #11542
Merged
Merged
Conversation
The Vue SFC assembler hoists imports out of a compiled `<script setup>` with
astExtractImportsAndStripTypes, which then ran a regex over the printed code
to strip leftover parameter annotations. The regex matched any `, name:
undefined` (or `null`, `string`, ...), so object properties were rewritten
too: `{ label: 'System', value: undefined }` became `{ label: 'System', value }`,
a shorthand for a variable that doesn't exist.
Parameter annotations are now removed on the AST before it is printed, so
object literals are left alone. TypeScript is already stripped by Babel
before and after this step; this only matters when that fails.
|
View your CI Pipeline Execution ↗ for commit 3e306eb
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On the Vue
/ns/asmHMR path,astExtractImportsAndStripTypes(hmr/helpers/ast-extract.ts) ran a regex over the printed code to strip residual parameter type annotations. It also matched object properties, so{ label: 'System', value: undefined }became{ label: 'System', value }, which references an undefined variable.What is the new behavior?
Parameter annotations are removed on the AST before printing, and the regex is gone. The variable-annotation pass is unchanged.
Tests: 2 cases in
ast-extract.spec.ts.Each new test fails without the change. The
@nativescript/vitesuite (163 files) andtsc -p tsconfig.lib.jsonpass on the branch.