Repository navigation
fix(http): report the real method and body to the network inspector - #11574
Open
NathanWalker wants to merge 1 commit into
Open
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
|
View your CI Pipeline Execution ↗ for commit 6b2f33d
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Both
http-request-internalimplementations report every request to the DevTools Network panel with a hard-codedmethod: 'GET'and nopostData, so POST/PUT requests show up as GETs with an empty Request Payload (#6897).What is the new behavior?
A shared
getDebugRequestMethodAndBody()helper supplies the request's actual method and, for string orFormDatacontent, its body aspostData, on both iOS and Android. Binary (ArrayBuffer) bodies are left out, as before. Covered by a new unit spec; not yet verified in Chrome DevTools against a device.Closes #6897.