Repository navigation
fix(android): isRealDevice returns false on emulators - #11575
Open
NathanWalker wants to merge 1 commit into
Open
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
|
View your CI Pipeline Execution ↗ for commit 66481fa
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On Android,
Utils.isRealDevice()gives the wrong answer. It returnstruewhenBuild.FINGERPRINTcontainsgenericorvbox, which means it reports emulators as real devices and devices as not real. Current Android Emulator images also have fingerprints withoutgeneric(for examplegoogle/sdk_gphone64_arm64/emu64a:...), so a simple negation would still miss them. The iOS implementation is already correct.What is the new behavior?
isRealDevice()returnsfalseon the Android Emulator and on Genymotion, andtrueeverywhere else. It detects emulators by:Build.HARDWAREbeinggoldfishorranchu(the emulator's virtual boards), orBuild.FINGERPRINTstarting withgenericor containingvbox.Nothing in core calls this on Android. Apps that worked around the inverted value will see it flip, so this should be called out in the release notes.
New unit tests in
utils/native-helper-for-android.spec.tscover a physical device, current and older emulator images, Genymotion, and missing build fields.This makes the API match its documented contract, so the separate
isSimulatorOrEmulatorproposal in #9065 shouldn't be needed.Closes #9064.