Repository navigation
fix(core): split className on any whitespace - #11577
Open
NathanWalker wants to merge 1 commit into
Open
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
|
View your CI Pipeline Execution ↗ for commit 0a68fa6
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
classNameis split withsplit(' '), so only single spaces separate classes. A class attribute that uses newlines or tabs, which Prettier 2.3+ produces when it wraps longclassattributes in Vue and Angular templates, gives class names with the line breaks and indentation still attached (for example"\n font-bold"). Those match no selector, so the styles silently don't apply. Repeated spaces also add an empty class.What is the new behavior?
classNameis split on any run of whitespace and empty entries are dropped, the same way browsers tokenize theclassattribute.The new spec
ui/core/view-base/class-name.spec.tscovers spaces, newlines and tabs, repeated whitespace, and clearing. Two of its cases fail without the fix. The full core suite passes (555 tests).Closes #9402.