Repository navigation
fix(ios): skip Switch color updates without a native view - #11579
Open
NathanWalker wants to merge 1 commit into
Open
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
|
View your CI Pipeline Execution ↗ for commit ff2afa4
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On iOS,
Switch.setNativeBackgroundColorwrites straight tonativeViewProtected. Whencheckedchanges while the Switch has no native view, which happens with framework renderers setting properties around creation or disposal, the call throwsTypeError: Cannot set property 'onTintColor' of null(#10101). On iOS 26+ the color update also runs from asetTimeoutafter the toggle animation, so it can fire after the view is gone. The deferred corner-radius update in the same method already guarded against this; the main path didn't.What is the new behavior?
setNativeBackgroundColorreturns early when there's no native view. Colors are still applied the next time the native view exists, through the normal property sync.The new spec
ui/switch/index.ios.spec.tscovers the missing-view case and a live-view color application. The missing-view case fails without the fix. The full core suite passes (553 tests).Closes #10101.