Repository navigation
fix(devtools): show non-string ApplicationSettings values - #11580
Open
NathanWalker wants to merge 1 commit into
Open
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
|
View your CI Pipeline Execution ↗ for commit 4646ceb
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The devtools Storage panel reads every ApplicationSettings key with
ApplicationSettings.getString(key). On Android that'sSharedPreferences.getString(), which throwsjava.lang.ClassCastException: java.lang.Boolean cannot be cast to java.lang.Stringfor any key stored withsetBooleanorsetNumber. As a result, opening Storage fails for any app with a non-string setting (#10513).What is the new behavior?
ApplicationSettingsKeyValueProvider.getValuetries the string, boolean and number getters in turn and returns the first one that succeeds, as a string. Missing keys still returnundefined. Writes are unchanged.Verification: I ran a one-off Vitest spec against a mocked
ApplicationSettingswhose getters throw on a type mismatch, the way Android's do. String, boolean and number keys all read back as'text','true'and'2.5', and the missing key staysundefined. The same spec fails without this change.tscforpackages/devtoolsreports no new errors.Closes #10513.