Repository navigation
fix(android): create prompt and login inputs from the dialog context - #11582
Open
NathanWalker wants to merge 1 commit into
Open
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
|
View your CI Pipeline Execution ↗ for commit ae2255d
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On Android,
prompt()creates itsEditTextfrom the current activity, andlogin()creates bothEditTexts and theirLinearLayoutfrom the application context. Neither uses the context of theAlertDialog.Builderthat thethemeoption is applied to, so a dialog themed throughoptions.theme(or the app's dialog theme) renders its inputs with a different style. The application context also carries no theme at all (#11068).What is the new behavior?
The inputs and the login layout are created from
alert.getContext(), which is the builder's themed context, so they follow the same theme as the dialog. Apps whoselogin()inputs relied on the unthemed application-context look will now see them styled like the rest of the dialog, which is the intent of thethemeoption.The new spec
ui/dialogs/index.android.spec.tschecks the context each view is constructed with, for bothpromptandlogin. It fails without the fix. The full core suite passes (553 tests).Closes #11068.