Repository navigation
fix(ios): preserve lazy controller loading during layout invalidation - #11587
Open
rafaelaugustos wants to merge 1 commit into
Open
rafaelaugustos wants to merge 1 commit into
rafaelaugustos wants to merge 1 commit into
Conversation
|
View your CI Pipeline Execution ↗ for commit 91337f9
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
rafaelaugustos
marked this pull request as ready for review
October 25, 2026 16:40
This was referenced Oct 25, 2026
Merged
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When a Frame is attached below a direction-bearing root before
Application.run(), inherited CSS direction callsrequestLayout(). ReadingviewController.viewthere eagerly loads the navigation controller beforeUIApplicationMain; on iOS 18.6 the resulting app terminates on TextField focus with the UIKit gesture-graphtargetNodeassertion.What is the new behavior?
Use
viewIfLoadedwhen invalidating the controller view. Layout flags, ancestor propagation and invalidation of already loaded native views remain intact. Android already invalidates only an existing native view; no public API or declaration changes are needed.Fixes #11586.
Validation
npx nx run core:test --skip-nx-cache: 568 passed, 1 skipped, 44 files passed.requestLayout()pass keyboard editing and cancelled/committed native Back on iPhone/iPad simulators running 18.6.controller.viewbefore startup still crashes with the patch: the negative control isolates early view loading, without CSS direction.apps/automated; that complete app suite was not run. Interaction coverage comes from the external Core/Vue/router fixture and XCTest runner linked below.Reproduction, reversible pinned-dependency patch, XCTest sources and results: rafaelaugustos/vue-router-ns#160 (companion reproduction and evidence PR).
Video
Actual iOS 18.6 simulator recording using the published router with only this Core correction: inherited LTR, tabs control, tabs with inherited LTR. Each flow types into a TextField, reverses native Back while preserving the draft, then completes Back.
core-lazy-controller-navigation.mp4