← 输入框|github.com|刷新
Skip to content

Add a pre-linting file #130

Closed
Closed

Description

@abarya

I think there is a need to add a file that can check for linting errors before pushing changes to the remote repo.

Activity

  1. vaibhavsingh97 commented on Oct 7, 2017

    @vaibhavsingh97
    Member

    @abhishekarya286 Please use issue template to create new issue. 😄
    Also, Please mention example/screenshot/link wherever necessary. Thanks 😄
    Are you talking about editorconfig?

  2. jarifibrahim commented on Oct 13, 2017

    @jarifibrahim
    Member

    @vaibhavsingh97 We should add linter config files and configure Travis CI to perform linting on our code. This process ensures that all the code we write follows the standard convention.
    Pylint is one such linter for Python.

  3. vinaypuppal commented on Dec 24, 2017

    @vinaypuppal
    Contributor

    Hi guys, can I work on this?

    These are the things I am thinking to implement in PR

    • Configure Flake8 linter.
    • Configure yapf (a python code formatter from google).
    • Configure pre-commit so flake8 and yapf are run for every git commit.
    • Update Readme on how to install pre-commit hooks.
  4. anubhakushwaha commented on Dec 25, 2017

    @anubhakushwaha
    Member

    @vinaypuppal Thanks for bringing such a cool thing like yapf, I went through it's documentation and think it would be really useful for us. cc @tapasweni-pathak @jarifibrahim @vaibhavsingh97 What do you think 😄

  5. vaibhavsingh97 commented on Dec 25, 2017

    @vaibhavsingh97
    Member

    Thanks @vinaypuppal for introducing yapf to us ✨ and feel free to send PR. @anubhakushwaha Yeah! It will be useful for us. 👍

  6. vinaypuppal commented on Dec 25, 2017

    @vinaypuppal
    Contributor

    Sure @vaibhavsingh97

    Yes its an awesome tool which I found recently while searching for python alternative for prettier(an awesome opinionated code formatter tool in javascript ecosystem).
    BTW, prettier team is working on python support as well.(https://github.com/prettier/prettier-python) but its under development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions