Repository navigation
Added Registration - #41
Conversation
|
@tapasweni-pathak @nikhita @jarifibrahim Please review |
jarifibrahim
left a comment
There was a problem hiding this comment.
@vaibhavsingh97 This is a huge pull request. You should never make these many changes in one PR. Always try to make atomic commits. :)
One more thing you should be careful about is the indentation settings in your IDE. I believe most of the changes in this PR have been made by the auto-format feature of the IDE.
BTW, I pulled your code and ran it locally. The registration and login process doesn't seem to work.
Please fix it. We cannot merge untill it works.
You just need to make some minor changes then we can merge your code. Good job :)
| @@ -0,0 +1,7 @@ | |||
| <component name="InspectionProjectProfileManager"> | |||
There was a problem hiding this comment.
This file is generated by Pycharm and you shouldn't add it.
Please remove this file and all the files in the .idea directory.
| transition: opacity 0.7s ease-in-out; | ||
| font-family: "Montserrat", sans-serif | ||
| padding: 0; | ||
| margin: 0; |
There was a problem hiding this comment.
Most of the changes in this file are related to indentation. Please undo these indentation changes. It's preferable to use a tab size of 2 spaces in css files.
| <span class="col-sm-6 left-align"> | ||
| <li> | ||
| <a href="https://www.facebook.com/opensourcehelpcommunity/"><i class="fa fa-facebook" aria-hidden="true"></i></a> | ||
| <a href="https://www.facebook.com/opensourcehelpcommunity/"><i |
| </form> | ||
|
|
||
| {% else %} | ||
|
|
|
|
||
| # SECURITY WARNING: don't run with debug turned on in production! | ||
| DEBUG = os.getenv("DEBUG", False) | ||
| DEBUG = os.getenv("DEBUG", True) |
There was a problem hiding this comment.
DEBUG should be set to False.
| ) | ||
|
|
||
| EMAIL_BACKEND = 'django.core.mail.backends.smtp.EmailBackend' | ||
| EMAIL_USE_TLS = True |
There was a problem hiding this comment.
Change this and following lines to os.getEnv('EMAIL_USE_TLS). This way it is easier to change the email server and related settings.
| </div> | ||
| </div> | ||
| </nav> | ||
| <nav class="navbar navbar-inverse navbar-static-top navbar-fixed-top"> |
There was a problem hiding this comment.
Indentation error in the entire file.
| <div class="col-xs-12"> | ||
| <div class="social"> | ||
| <ul> | ||
| <div class="container-fluid"> |
There was a problem hiding this comment.
Why change content to container-fluid?
| urlpatterns = [ | ||
| url(r'^admin/', admin.site.urls), | ||
| url(r'', include('main.urls')), | ||
| url(r'^accounts/', include('registration.backends.simple.urls')), |
There was a problem hiding this comment.
You're using the simple backend and you've created the files (email related) for the default backend. You should include registration.backends.default.urls.
|
@jarifibrahim Thanks for reviewing. Can you please tell me the error? |
|
@jarifibrahim Updated the suggested changes. Please review again |
jarifibrahim
left a comment
There was a problem hiding this comment.
The login/registration isn't working. Does it work on your machine?
Also, you might want to squash your commits into a single commit. Ping me on slack if you don't know how to do it.
| body { | ||
| overflow-x: hidden; | ||
| padding-top: 50px; | ||
| margin-bottom: 120px; |
There was a problem hiding this comment.
This change breaks the layout. You might want to remove it.
| </li> | ||
| </span> | ||
| <span class="col-sm-6 backToTop right-align"> | ||
| <span class="col-sm-6 back-to-top right-align"> |
| border-color: #24292e; | ||
| } | ||
|
|
||
| .container-fluid { |
There was a problem hiding this comment.
Generally, it is a bad idea to apply styles to bootstrap classes. What if container-fluid is used somewhere else on the same page? It will automatically get padding-left: 0px which is not the intended behavior. You should add your own class/id if you wish to tweak a bootstrap element.
| <button type="submit" | ||
| class="btn btn-lg btn-primary btn-block">{% trans 'Submit' %}</button> | ||
| </div> | ||
|
|
| <script src="{% static "main/js/script.js"%}"></script> | ||
| <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script> | ||
| <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js" integrity="sha384-Tc5IQib027qvyjSMfHjOMaLkfuWVxZxUPnCJA7l2mCWNIpG9mGCD8wGNIcPD7Txa" crossorigin="anonymous"></script> | ||
| <script src="{% static " main/js/script.js " %}"></script> |
There was a problem hiding this comment.
Change static " main/js/script.js " to static "main/js/script.js"
|
@tapasweni-pathak Please review and merge.
|
|
Thanks for the instructions, @vaibhavsingh97! I checked the changes locally and it works perfectly. 🙌 @jarifibrahim @tapasweni-pathak Since you reviewed the PR, I'll leave it to you to merge it. |
|
Merging this since we have 2 approvals. Well done @vaibhavsingh97 |

fixes #25




Screenshot after fix: