← 输入框|github.com|刷新
Skip to content

Small fixes, ignored override comments, harden-runner v2.22.4 - #31

Open
irvingpop wants to merge 2 commits into
mainfrom
minors-issue24
Open

irvingpop wants to merge 2 commits into
mainfrom
minors-issue24

Conversation

@irvingpop

Copy link
Copy Markdown
Member

Summary

Test plan

  • cd review && uv run pytest tests/unit: 3033 passed (3016 before)
  • Independent review: pass, no Critical or Important findings
  • After merge: release (make release) to move the review rulesets to the new SHA

🤖 Generated with Claude Code

irvingpop and others added 2 commits November 6, 2026 15:32
…l lint, fix eval-test docs

- Rejected /oc-review comments now show one line in the summary and the
  job log with the reason; verdict and risk do not change.
- Graph-off evidence ignores conditional or negated text before the phrase.
- eval.yml lint rejects workflow-level and job-level defaults and step shell.
- Docs and comments match live eval-test (prevent self-review off) and
  the approval-free eval run on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Audit mode and all allowlists stay. Upstream issue 708 is fixed in
v2.22.4; block mode waits for the issue 24 soak.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@irvingpop
irvingpop requested a review from a team as a code owner November 6, 2026 23:39
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

🔴 Hold deployment: Claude of Duty identified 1 item requiring attention

Mission: Review the code. Protect the branch. Deploy the future.

Caution

Out of range. This change is too large for the model review. File checks ran, but model checks did not. A maintainer can waive this.
Next step for the author: split the change, or ask a maintainer for a waiver (under "Waiver" below).

Severity Effect Where Finding Found by
⚠️ Not run Blocks, waivable Model passes Too large for automatic review. File checks ran, model checks did not. Workflow (code, no model)
File checks Review Security Supply chain Dependency review Coverage
✅ ok, 5 signals ⚠️ skipped, too large ⚠️ skipped, too large ⚠️ skipped, too large ✅ ok ✅ complete

Run 42313321619, attempt 1 for head 80d0827 into main. The required workflow in the merge box is the result that counts.

Claude of Duty never approves a PR. A human reviewer gives the final approval.

🔑 Waiver: how a maintainer clears this

This PR fails for waivable reasons only. A person with write or admin access, who is not the PR author, posts this exact line as a new comment and replaces <reason> with the reason. Then they re-run the newest run of the required workflow through the GitHub REST API (POST .../actions/runs/{run_id}/rerun). Do not edit the comment afterwards. Do not close and reopen the PR to apply the waiver.

/oc-review override 80d082749698ef6a7ea7ebed7fba12f2e55db90a 08aa87215d27bf75a5bb78ef75ab559d861e4b4e <reason>

A waiver covers the code at this exact head and merge base. Any new push needs a new waiver.

📋 Full review record: reasons, checks, signals, finding details, model summaries, token usage

Reviewed snapshot

Head SHA Merge base SHA Base branch Run
80d082749698ef6a7ea7ebed7fba12f2e55db90a 08aa87215d27bf75a5bb78ef75ab559d861e4b4e main 42313321619, attempt 1

Reasons the gate failed

Reason Waivable? Detail
Change too large for the model review ✅ yes too large for automatic review

Checks (code, no model)

Check Result Detail
Hard blocks ✅ none
Coverage ✅ complete files in comparison 13, files collected 13, trees complete
Dependency changes ✅ none
Dependency review job ✅ success

Signals (context only, never block)

  • ⚠️ Sensitive path changed: change to workflow, in .github/workflows/claude-review.yml
  • ⚠️ Sensitive path changed: change to workflow, in .github/workflows/eval.yml
  • ⚠️ Sensitive path changed: change to workflow, in .github/workflows/test.yml
  • ℹ️ Very long line: lines longer than 500 characters, in docs/build-plan.md, lines 109 225
  • ℹ️ Very long line: lines longer than 500 characters, in docs/claude-review-design.md, lines 43 199 508 615 713 714 880 1033 1035

Dependency changes

None.

Finding details

Model output from untrusted input. Check it before you act on it. Verified means only that the quoted text is at that place. It does not mean the claim is true.

Blocking is decided by code from category and severity, never by the model. A finding in a blocking category blocks only at high or critical severity.

No findings from the passes that ran. The Review, Security, Supply chain pass did not run, so this is not a clean result.

Model summaries

Model output from untrusted input. Check it before you act on it. Verified means only that the quoted text is at that place. It does not mean the claim is true.

Pass Status Model Summary
Review ❌ skipped-size No summary. Reason: bundle status skipped-size
Security ❌ skipped-size No summary. Reason: bundle status skipped-size
Supply chain ❌ skipped-size No summary. Reason: bundle status skipped-size

Token usage

No token usage was recorded for any pass.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant