Repository navigation
Reject ampersand-separated DSC resource bodies - #2288
Merged
Christoph Bergmeister (bergmeister) merged 3 commits intoOct 28, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Reject ampersand-separated DSC resource bodies
Oct 28, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The alias-rule separator change has no active review issues blocking approval.
No open issues 🎉
What changed in this PR
This PR updates AvoidUsingAlias so commands separated from a following script block by & are not incorrectly treated as DSC resource declarations.
Changes:
- Extends the statement-separator check to recognize both
;and&. - Adds regression coverage for
gci . &followed by{}, expecting an alias diagnostic.
| File | Description |
|---|---|
| Tests/Rules/AvoidUsingAlias.tests.ps1 | Adds the ampersand-separated case and updates the expected diagnostic count. |
| Rules/AvoidAlias.cs | Renames the separator helper and adds ampersand detection. |
Review effort: Balanced
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 28, 2026 21:59
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 28, 2026 21:59
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2289
October 28, 2026 22:13
Christoph Bergmeister (bergmeister)
merged commit Oct 28, 2026
6dcd4a4
into
copilot/fix-auto-correct-aliases
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-code-comments-in-review-thread
branch
October 28, 2026 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In fallback configuration ASTs, a command followed by
&and a standalone block could be mistaken for a DSC resource declaration, suppressing the command’s alias diagnostic.&as a statement separator alongside;when checking adjacent command and block statements.{ gci . & {} }