← 输入框|github.com|刷新
Skip to content

Honor -Recurse when Get-ChildItem uses -Name - #28078

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
daxian-dbw:dir-name-recurse
Oct 9, 2026
Merged

Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
daxian-dbw:dir-name-recurse

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

PR Summary

Fix Get-ChildItem -Name so recursive searches with a wildcard or exact leaf path enumerate matching files in subdirectories. The name-only path now reuses the recursive path normalization already used by regular item enumeration.

Add regression coverage for wildcard and exact leaf paths, including searches relative to the current directory and -Depth 0 behavior.

PR Context

Get-ChildItem *.md -Recurse -File -Name previously expanded *.md only in the starting directory. The resolved files are not containers, so recursive name enumeration never received a directory root and did not visit subdirectories.

Validation:

  • Debug build with regenerated resources
  • Get-ChildItem.Tests.ps1: 31 passed
  • FileSystemProviderExtended.Tests.ps1: 78 passed

Before the fix:

## PWD is Q:\yard
PS:35> dir *.md -Recurse -File

    Directory: Q:\yard\delme

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---           9/23/2026 12:47 PM              0 delme.md

    Directory: Q:\yard

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---           9/21/2026 11:57 AM           1402 note.md

PS:36> dir *.md -Recurse -File -Name
note.md

After the fix:

PS Q:\yard> dir *.md -Recurse -File -Name
note.md
delme\delme.md

PR Checklist

Copilot AI lite review requested due to automatic review settings September 24, 2026 04:02
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from a team as a code owner September 24, 2026 04:02
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

This comment was marked as outdated.

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 24, 2026
@daxian-dbw Dongbo Wang (daxian-dbw) changed the title Honor -Recurse when Get-ChildItem uses -Name Honor -Recurse when Get-ChildItem uses -Name Sep 24, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
{
// If we're recursing, do some path fixups to match user
// expectations, but only if the last part is a file and not a directory:
if (recurse && !path.EndsWith(Path.DirectorySeparatorChar) && !path.EndsWith(Path.AltDirectorySeparatorChar))

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed code here was actually moved to the NormalizePathForChildItemRecursion method below, with no change at all.

This comment was marked as outdated.

This comment was marked as off-topic.

@iSazonov

Copy link
Copy Markdown
Collaborator

Is your description in "Before the fix:" correct? It seems #9014 is not fixed jet. Also PowerShell Committee conclusion was to reject the change.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 25, 2026 •

Copy link
Copy Markdown
Member Author

This PR will fix #9014:

PS Q:\yard> Get-ChildItem -Path *.md -Recurse -Name
note.md
.abc\abc.md
delme\delme.md
tmp\hello\world\world.md

PS Q:\> Get-ChildItem -Path Q:\yard\*.md -Recurse -Name
note.md
.abc\abc.md
delme\delme.md
tmp\hello\world\world.md

I didn't know that issue and thanks for pointing me to it.

I disagree with the WG conclusion. It's hard to imagine someone would depend on this breaking behavior -- they specify -Recurse but Get-ChildItem doesn't traverse the directories. I think if there is anyone who is doing that today, it's very likely they didn't know it's broken and assumed it works the way they expected (same as dir -path ... -Recursive but just output the names).

Note that Get-ChildItem -Path . -Include *.md -Recurse -Name works today, and that makes it hard to justify the -Name behavior except for accepting that it's broken. This kind of inconsistency impacts how AI can write high-quality PowerShell commands when using PowerShell as the shell-invocation tool on Windows.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Oct 3, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 5d871eb into PowerShell:master Oct 9, 2026
69 checks passed
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the dir-name-recurse branch October 9, 2026 17:21
@daxian-dbw Dongbo Wang (daxian-dbw) removed the Review - Needed The PR is being reviewed label Oct 9, 2026
@BrucePay

Copy link
Copy Markdown
Collaborator

This is a breaking change but is not marked as such. It will break patterns i use like renaming a directory to "directory.old", "directory.old.old" etc. It should at least be documented as a breaking change in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants