Repository navigation
Remove the redundant #if UNIX check from the Unix only code - #28120
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoOct 9, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed change is narrowly scoped and has no unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Removes a redundant Unix preprocessor guard from the Unix-only implementation.
Changes:
- Simplifies Unix-only cursor repositioning logic.
| File | Description |
|---|---|
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostRawUserInterface.cs |
Removes the redundant #if UNIX guard. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Justin Chung (jshigetomi)
approved these changes
Oct 9, 2026
Justin Chung (jshigetomi)
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the platform preprocessor structure and current required checks. The nested UNIX guard is redundant within the existing Unix-only branch; no merge blockers found.
Dongbo Wang (daxian-dbw)
merged commit Oct 9, 2026
9bc534b
into
PowerShell:master
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove the redundant
#if UNIXcheck from the Unix only code.