Repository navigation
Run C API Clippy with its crate-local PyO3 configuration - #9385
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Exclude rustpython-capi as a selected target in generic workspace Clippy, then lint its targets from crates/capi so Cargo loads the existing RustPython ABI3T PyO3 configuration. The shared steps cover Linux and conditional macOS/Windows Clippy without changing their filters. Keep existing features, runtime test commands, cache, permissions, exports and fixture behavior unchanged. This complements rather than replaces the C API build/export work in RustPython#9270. Assisted-by: OpenAI Codex:model version unavailable
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separate C API linting from the generic workspace Clippy invocation:
rustpython-capias a selected workspace Clippy target.cargo clippy --locked --all-targets -- -Dwarningsfromcrates/capi.Cargo invoked at the workspace root does not load member-crate configuration. The dedicated invocation uses the existing
crates/capi/.cargo/config.toml:PYO3_NO_PYTHON=1and the RustPython 3.15RustPython-abi3t-3.15PyO3 configuration. No new feature or ABI fallback is introduced. Root benchmarks retain their independent configuration.The C API library can still be a dependency of another selected workspace crate. The exclusion separates its explicitly selected test/example/bench targets from the root build context; it does not remove all C API production code from the workspace dependency graph.
The edited steps are shared by Linux and conditional macOS/Windows Clippy. Existing filters, matrices, environment, caches, permissions, features, exports, fixtures, and runtime test commands are unchanged. This is complementary to #9270's build/export work, not a modification of its contributor branch or a replacement for its export inventory.
Validation
self-repositoryfindings on baseline and candidate (exit 12 on both). No new findings or suppression changes; this is not a clean scan.cargo clippy --locked --offline --all-targets -- -Dwarnings, invoked fromcrates/capiwith the existing ABI3T configuration.No local C API tests, interpreter startup, lifecycle operations, or other runtime tests are executed.
--all-targetscompiles targets; it does not run tests. Linux lint evidence does not establish Windows/macOS or runtime correctness. Standard existing hosted CI remains responsible for its unchanged jobs on the new head.AI assistance: OpenAI Codex, disclosed in the commit trailer.
Local lint validation used the exact candidate based on
f3c443a. Before publication, main advanced to30b8239donly through unrelated wasm JavaScript package updates (#9377 and #9378); workflow, Cargo and C API inputs were unchanged. The tested candidate was not rebased. Hosted CI must validate its actual merge context separately.