Repository navigation
Conversation
…itten as applyCascade writes a page
…gh its consequence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first pass at plain names in core, one change per commit so any one can be dropped. Every name here is provisional: the plain-speaking pass has the final word, and this is the list for it to audit, not the audit.
The method is the literal action: who acts, on what, said in the plainest words, and the name is that sentence shortened. The start list is the verified items from the pocketed legibility report plus two words the naming law names outright.
Names
matched.currentRoutesmatched.chainafterCommit(work, event, false)afterCommit(work, event, { precommitRan: false })router.activeAbortrouter.initialAbortlandNotFoundapplyNotFoundapplyCascadedoes for a matched navigationnavigator.project()navigator.readPlatform()cellFordefineCell*Forbuilds and returnsbagForhookContextlandapplyAnsweridentityRunstopIdentitylifetimeabortControllersettlingtoldRoutesborn,adopt,adopteduntaken,takeRuns,takentold(local)updateframed(local)hasSliceThe born record
{ route, run, adopted, changed, latest }wrapped a run; it is folded into the run itself, so the list and its items are not the same word and there is one record per run. That is the one change here that is not a rename alone.Structure, from the same report
eachloops over ablockedflag; they are onesomeover the chain and one over the guards.liveContext, stacked on that method's own; it is ondataFornow.(props.under ? isActive : isCurrent)(...); it calls each by name through an accessor.chore/route-defaultsride along as the first commits, so that branch can be deleted.Left out on purpose
keys,last,isNode): ruled, a native where utils has a word is not a finding here.logErroris the one seam on purpose, and the rest is bytes.slotDeclaredBelowstays, since declared is the word the explicit-empty rule needs.identityFreshstays as the one word left that is not quite literal: the answer no navigation has taken yet.Proof
The probes run against main's router and this branch's, from a worktree linked absolutely and shown live, and their output is identical line for line: the store probe, the three core seam probes, the plain and override jsdom probes, and the door and live Solid probes under jsdom with the real solid-js. The runs probe's table, runs per cause at the slice seam, is identical too; its timing tail is stale and fails the same way on both trees.
Core is up seven bytes: the
precommitRankey survives minification and three names grew a character or so. If the headline says no, that commit drops alone. The scaffold is down nineteen from the fold.