← 输入框|github.com|刷新
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TionAPI/tion_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: TionAPI/tion_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 8 files changed
  • 1 contributor

Commits on Oct 29, 2021

  1. fix(tion): fix heating detection 

    To be sure that heating is on we should check that:
 * heater is on (breezer may heat)
 * out_temp > in_temp (something heat air)
 * in_temp is more thant 3 degree awy from target temperature (some internal breezer logic may be missed here, it may be not only one condition)

Fix #32
    @IATkachenko
    IATkachenko committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    4ba3c7a View commit details
    Browse the repository at this point in the history

  2. test(tion): add unit tests for __detect_heating_state

    @IATkachenko
    IATkachenko committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    eb4a424 View commit details
    Browse the repository at this point in the history

  3. refactor(tion): move updating sate from breezer to own function

    @IATkachenko
    IATkachenko committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    f253205 View commit details
    Browse the repository at this point in the history

  4. feat(tion): allow skipping breezer querying while get() 

    If we don't disconnects from breezer, then nothing could change settings and we may skip getting breezer state while get()
Initial state of have_breezer_state is False -- we don't know breezer state.
That it goes to True in _get_data_from_breezer if we have data from breezer and may decode it and to False again while connect/disconnect calls.
    @IATkachenko
    IATkachenko committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    87834bb View commit details
    Browse the repository at this point in the history

  5. feat(tion): set internal state based on user request 

    It will allow us to don't make new request to breezer after set to get updated params i.e. use set() get(skip_update=True) sequence to get updated params without connecting to breezer.
Also set() set() calls may be done without additional internal get().
    @IATkachenko
    IATkachenko committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    e2b7646 View commit details
    Browse the repository at this point in the history

  6. refactor: rename internal property target_temp to heater_temp 

    We use heater_temp outside, so it is comfortable to use same name for internal property.
    @IATkachenko
    IATkachenko committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    e73497f View commit details
    Browse the repository at this point in the history
Loading