Repository navigation
Conversation
pratushnyi
approved these changes
Jun 17, 2026
pratushnyi
approved these changes
Jun 17, 2026
Contributor
|
FYI @baev Would be great, if I get feedback, what the intention was (and if safety is more important here than performance) (We may try https://github.com/stewartsmith/libeatmydata as workaround to disable all fsync-calls) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Allure now writes filesystem result artifacts more safely, so test results do not expose partially written files when attachment or result persistence fails. Attachments, test result JSON, and container JSON are staged first and only published to the final Allure results path after the write is completed and synced.
This helps runs that persist large attachments or other heavy result data fail clearly instead of leaving behind final-looking files that cannot be read reliably afterwards.
Checklist