@allure.step decorator fails if one of the method parameters has a default value

I have a method that has the default argument set to "None". (it can be string as well)

@allure.step(
    "Send message: '{message}' on {channel} with props: '{props}'")
def send_message(
        self,
        channel: str,
        message: str,
        username: str = None,
        props: Dict = None) -> None:
    ...

Calling this method without the props parameter:

self.bot.send_message(
       channel=self.DZIUNIA['mm_channel_id'],
       message=letter)

causes a Python exception:

E KeyError: 'props'

I have seen this too.
I assume the hook doesn't get a 'props' in this case, therefore fails. Yet, the function would be the next step after the hook, where it forces props = None making it a known variable.

Not sure if it's a bug, or working as intended, due to order of operations.
To that end, my workaround would be using a context manager for the whole step:

def send_message(
        self,
        channel: str,
        message: str,
        username: str = None,
        props: Dict = None) -> None:
     with allure.step(
        "Send message: '{message}' on {channel} with props: '{props}'")
        <code>

Hope that helps for the mean time!

I don't know if it's a bug either.

I will try to replace decorator by your solution.

Thanks!

The problem is here - in this case only kwargs will be treated as a parameters
But actually we need to take all default parameters from function object and merge them with kwargs

Is there any updates?
Please note that the issue occurs on 2.8.15 version as well

Is there any updates?
Please note that the issue occurs on 2.8.15 version as well

PR #569

Add an ability to pass positional args as keyword (fixes #440) (#569)

Add an ability to pass positional args as keyword (fixes allure-frame…

Navigation Menu

Repository navigation

@allure.step decorator fails if one of the method parameters has a default value #440

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

@allure.step decorator fails if one of the method parameters has a default value #440

Description

Activity

mlewandowskipear commented on Oct 31, 2019

tanistra commented on Oct 31, 2019

ocherniavskyi-lohika-tix commented on Feb 20, 2020

Araksya-Hambaryan commented on May 25, 2020

Denis-Alexeev commented on Mar 3, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions