Repository navigation
MINOR: Simplify assertThrows usage in ConnectionTest - #1440
Draft
siddiqueirshad wants to merge 2 commits into
Draft
siddiqueirshad wants to merge 2 commits into
siddiqueirshad wants to merge 2 commits into
Conversation
siddiqueirshad
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
November 3, 2026 13:33
Member
|
@siddiqueirshad please fix the PR title to comply with the guidelines (should be MINOR:, not GH:), thanks! |
lidavidm
marked this pull request as draft
November 3, 2026 23:09
Signed-off-by: siddiqui irshad <mohdirshad1306@gmail.com>
siddiqueirshad
force-pushed
the
simplify-connection-test-assert-throws
branch
from
November 3, 2026 23:32
3091fd3 to
1f78db1
Compare
This comment has been minimized.
This comment has been minimized.
Author
|
@lidavidm Updated the PR title and commit message to start with \MINOR:\ as requested. Thank you! |
Member
|
CI is failing. |
Member
|
I applied spotless fix and rebase the PR. |
Author
|
Thank you so much @jbonofre for the spotless fix and rebase! |
Author
|
Thank you so much @jbonofre for applying the spotless fix and rebasing the PR! Really appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant try-with-resources and fail() calls inside assertThrows blocks in ConnectionTest, allowing JUnit to handle exception assertions cleanly.