Repository navigation
Conversation
Follow-up to apache#1363. - Don't copy `hostnameOverride` in the `ArrowFlightSqlClientHandler.Builder` copy constructor. The override is only valid for the original host and port, so a copied builder no longer carries it to another location by default. `getStreams` already sets it explicitly for each endpoint, so behavior is unchanged. - Trim `ArrowFlightConnectionConfigImpl.getHostnameOverride()` and return `null` for blank values, as its Javadoc says. - Record the `:authority` the server receives in `ConnectionTlsHostnameOverrideTest`. The plaintext test now checks that the connection's own host and port are sent, and a new test checks that the override replaces the whole authority and that a port can be included. - Document that the override replaces the port in `:authority`, and that a port can be included. Closes apache#1442.
lidavidm
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1363.
hostnameOverridein theArrowFlightSqlClientHandler.Buildercopy constructor. The override is only valid for the original host and port, so a copied builder no longer carries it to another location by default.getStreamsalready sets it explicitly for each endpoint, so behavior is unchanged.ArrowFlightConnectionConfigImpl.getHostnameOverride()and returnnullfor blank values, as its Javadoc says.:authoritythe server receives inConnectionTlsHostnameOverrideTest. The plaintext test now checks that the connection's own host and port are sent, and a new test checks that the override replaces the whole authority and that a port can be included.:authority, and that a port can be included.Closes #1442.