Repository navigation
Run four tests that were missing @Test - #1094
Merged
Merged
Conversation
TestBeanNameELResolver.testGetCommonPropertyType01/02 now expect String.class, which getCommonPropertyType always returns. TestSSLValve.testSslCipherUserKeySizeHeaderBadFormat lost its annotation when the valve started logging invalid key sizes; it now uses its own log filter and checks the warning. TesterLogValidationFilter no longer fails on a record without a throwable. TestMemoryUserDatabase.testReloadUserDatabase now reloads after the file is written, using its own file and database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four test methods have no
@Test, so they never run. With@Testadded, each failed until fixed:TestBeanNameELResolver.testGetCommonPropertyType01and02: their Javadoc says "Confirm it returns String.class", but they assertednull.BeanNameELResolver.getCommonPropertyTypealways returnsString.class, so they now assert that.TestSSLValve.testSslCipherUserKeySizeHeaderBadFormat: d73f69e ("Valve now logs non-integer header values") removed its@Test(expected = NumberFormatException.class)without adding@Test. Run as it was, it failed with aNullPointerExceptioninTesterLogValidationFilter. The logger still had the filter fromtestSslClientCertBadFormat, which looks for a throwable, and the new warning has none. The test now adds its own filter, as the other tests in the class do, and checks that the warning is logged.TesterLogValidationFilteralso no longer fails on a record without a throwable when it looks for one; it treats the record as not matching.TestMemoryUserDatabase.testReloadUserDatabase: it calledopen()inside the try-with-resources block, before the writer was closed, so the file was still empty and parsing failed with "Premature end of file". It also overwrote the file of the database that the other tests share. It now uses its own temporary file and database, liketestDataEscaping, and reloads after the writer is closed.ant testpasses for the three classes, andant validatepasses.