Repository navigation
Conversation
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "%%writefile generate_lcs.py\n", |
There was a problem hiding this comment.
Is the %%writefile magic useable in this website framework?
There was a problem hiding this comment.
This should work, but we might need to double check that it writes to the correct location
|
I'm going to need a bit of help with this PR. The section headers yield warnings and don't render, saying: |
|
Thanks @bmorris3! I'll let others take a closer look at the content, but a few comments:
|
|
Colab notebook here: https://colab.research.google.com/drive/1A02gYb6aOOcXUnb0MlUKFoNX9aEtDJ6N I think the issue that both @adrn and @bsipocz brought up about the time series class is an important one. Maybe y'all can discuss? Or we can discuss on the learn telecon this morning. |
|
The content of the tutorial itself looks pretty good. It would be useful to point out that in this specific case there are a couple of potential packages that users should use instead of making their own class: astropy time series and lightkurve. I think it is actually good to have as an example something that has a better/more complete implementation elsewhere. |
|
👋 We have changed the build infrastructure and layout of files in the repo, so I am going to rebase this pull request and force push to your branch. If you have any local changes that haven't been pushed, please push them by the end of this week (October 1). After I have rebased to bring the new build machinery in, please let us know if you would like to continue working on this tutorial or if you would rather someone else take it over. Thanks! |
|
Hi @bmorris3! I realise it has now been a number of years since you submitted this, but it looks basically complete. The only feedback that I see that hasn't been implemented is pointing the user to the existing light curve packages. I am happy to add this, if you are willing. I apologise for how long we've let this sit. Let me know what you think. |
|
Sure @ceb8. Since I made this PR, I put a better version of this notebook in astropy-workshop that I could push to this branch instead if you like. |
|
@bmorris3 That one looks great! Yes please push it here. Thanks! |
This is a little tutorial for creating your own Python object from scratch, building a
LightCurveobject and some related methods on it.This closes #408 (thanks for the tip, @kelle!).