Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Reasoning:
Having tutorial submissions just as issues means that we cannot take advantage of reviewnb, which makes the back and forth of a code review much more challenging since the reviewer must download the notebook to run, make their comments in the notebook and then upload the new version. By allowing new tutorials to come in as PRs the review process can use GithHub and ReviewNBs built in review functionality.
New workflow:
This would work much like the issue method. Incoming tutorial PRs, once everyone is happy with the notebook, will not be merged, but instead the new tutorial repo will be created and the PR will be closed with a link to the new repo.