← 输入框|github.com|刷新
Skip to content

Revert "Flaky Test Fixed in TestStructureSerialization" - #909

Merged
josemduarte merged 1 commit into
masterfrom
revert-903-flaky_test_fixed
Dec 7, 2020
Merged

josemduarte merged 1 commit into
masterfrom
revert-903-flaky_test_fixed

Conversation

@sbliven

@sbliven sbliven commented Dec 7, 2020

Copy link
Copy Markdown
Member

Reverts #903

I may have been hasty on mergin #903, which changes mmcif output column order.

@sbliven

sbliven commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

@Vidishab18 Thanks for bringing up these nondeterminism issues!

@Vidishab18

Copy link
Copy Markdown
Contributor

@sbliven
Was this PR initially missing some checks ?

@josemduarte josemduarte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants