Repository navigation
fix(config): don't warn about [commit] require_verified, read by the App - #656
Conversation
…tHub App reads The App is adding require_verified (GitHub's Verified badge on each commit). The CLI cannot see that verdict and leaves the key to the App, the way it leaves [jira] and [pull_request].
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance1 warning
Comparing Footnotes
|



Why
The GitHub App is adding
[commit] require_verified = true(every commit must show Verified on GitHub), in commit-check/commit-check-app#57. Only the App can read GitHub's verdict on a signature, so the CLI leaves the key alone, the same way it leaves[jira]and[pull_request].Before / after
Config:
Before (2.19.4):
After: no warning. The key is allowed only under
[commit];[branch] require_verifiedstill warns.Tests
pytest: 1474 passed; the one failure (test_load_config_file_permission_error) also fails onmainwhen run as root. Coverage 100%.ruff checkandruff format --checkclean. README pins already at v2.19.4.Summary by CodeRabbit
commit.require_verifiedsetting, preventing it from being incorrectly flagged as unknown.branch.require_verified, continue to be reported.