Repository navigation
fix(skill): find the draft message file in worktrees and submodules - #686
Merged
Merged
Conversation
The skill wrote the draft to .git/COMMIT_MSG_DRAFT, which fails in a worktree or a submodule, where .git is a file. It now asks git rev-parse --git-path for the location.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
The agent skill told the agent to write a multi-line draft to
.git/COMMIT_MSG_DRAFT. In a worktree or a submodule,.gitis a file, not a directory, so the write fails. The skill now gets the path fromgit rev-parse --git-path COMMIT_MSG_DRAFT, which resolves correctly in all three cases, and says to commit withgit commit -F "$draft".Before vs after
In a worktree created with
git worktree add:printf 'feat: x\n' > .git/COMMIT_MSG_DRAFTNot a directorydraft="$(git rev-parse --git-path COMMIT_MSG_DRAFT)"/repo/.git/worktrees/<name>/COMMIT_MSG_DRAFT;commit-check --message --compact "$draft"exits 0In a normal checkout,
$draftis still.git/COMMIT_MSG_DRAFT.Tests
tests/skill_test.pypasses, so every flag the skill uses still exists.