← 输入框|github.com|刷新
Skip to content

ci: publish to PyPI with Trusted Publishing to get provenance - #691

Merged
shenxianpeng merged 1 commit into
mainfrom
claude/project-thread-u7tjif
Nov 10, 2026
Merged

shenxianpeng merged 1 commit into
mainfrom
claude/project-thread-u7tjif

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Why

The v2.20.4 release page on PyPI says No provenance. publish.yml already uses pypa/gh-action-pypi-publish, but it uploads with password: ${{ secrets.PYPI_API_TOKEN }}. PyPI only accepts and shows PEP 740 attestations when the upload uses Trusted Publishing (OIDC). With a token the action skips them.

Change

  • PyPI step: drop the password: line, so the action uses the job's existing id-token: write (Trusted Publishing) and uploads attestations by default.
  • Job runs in a pypi environment (url: https://pypi.org/p/commit-check), matching the trusted publisher on PyPI.
  • TestPyPI dry run (workflow_dispatch) is unchanged and still uses TEST_PYPI_TOKEN.
  • actions/attest-build-provenance stays; it feeds gh attestation verify, which is separate from PyPI's provenance.

Before vs after

Before After
Upload auth Long-lived PYPI_API_TOKEN Short-lived OIDC token
PyPI release page No provenance Provenance from publish.yml
/integrity/.../provenance 404 Attestation bundle

Needed before merging

Add a trusted publisher at https://pypi.org/manage/project/commit-check/settings/publishing/ with owner commit-check, repository commit-check, workflow publish.yml, environment pypi. Without it the next release fails at the upload step. After one good release, delete the PYPI_API_TOKEN secret and revoke the token on PyPI.

PyPI only stores PEP 740 attestations, and shows provenance, when the
upload uses Trusted Publishing. Drop the PYPI_API_TOKEN password and
run the job in a pypi environment that the trusted publisher names.
@shenxianpeng
shenxianpeng requested a review from a team as a code owner November 10, 2026 08:33
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4fd02d8c-1cdd-4c45-bb2c-eb768dd68dfd
Commits

Reviewing files that changed from the base of the PR and between 17f4e06 and b469b40.

Files selected for processing: 1

  • .github/workflows/publish.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@shenxianpeng shenxianpeng self-assigned this Nov 10, 2026
@sonarqubecloud

Copy link
Copy Markdown

@shenxianpeng
shenxianpeng merged commit ab14f96 into main Nov 10, 2026
11 checks passed
@shenxianpeng
shenxianpeng deleted the claude/project-thread-u7tjif branch November 10, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant