Repository navigation
ci: publish to PyPI with Trusted Publishing to get provenance - #691
Merged
Merged
Conversation
PyPI only stores PEP 740 attestations, and shows provenance, when the upload uses Trusted Publishing. Drop the PYPI_API_TOKEN password and run the job in a pypi environment that the trusted publisher names.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
The v2.20.4 release page on PyPI says No provenance.
publish.ymlalready usespypa/gh-action-pypi-publish, but it uploads withpassword: ${{ secrets.PYPI_API_TOKEN }}. PyPI only accepts and shows PEP 740 attestations when the upload uses Trusted Publishing (OIDC). With a token the action skips them.Change
password:line, so the action uses the job's existingid-token: write(Trusted Publishing) and uploads attestations by default.pypienvironment (url: https://pypi.org/p/commit-check), matching the trusted publisher on PyPI.workflow_dispatch) is unchanged and still usesTEST_PYPI_TOKEN.actions/attest-build-provenancestays; it feedsgh attestation verify, which is separate from PyPI's provenance.Before vs after
PYPI_API_TOKENpublish.yml/integrity/.../provenanceNeeded before merging
Add a trusted publisher at https://pypi.org/manage/project/commit-check/settings/publishing/ with owner
commit-check, repositorycommit-check, workflowpublish.yml, environmentpypi. Without it the next release fails at the upload step. After one good release, delete thePYPI_API_TOKENsecret and revoke the token on PyPI.