Repository navigation
Fix for boost 1.70 (get_io_service() was deprecated and was removed) - #878
Merged
Merged
Conversation
Author
|
I forgot to keep compatibility with older ASIO versions. Now the pull request should be ok. |
deanberris
requested changes
Aug 8, 2019
deanberris
left a comment
Member
There was a problem hiding this comment.
Thanks, @enricodetoma!
Please find comments below.
deanberris
requested changes
Aug 9, 2019
deanberris
left a comment
Member
There was a problem hiding this comment.
Couple more requests and I think we're almost there... :)
deanberris
requested changes
Aug 9, 2019
deanberris
approved these changes
Aug 12, 2019
deanberris
left a comment
Member
There was a problem hiding this comment.
Thanks for this, @enricodetoma!
yogev-lb
added a commit
to LightBitsLabs/osmosis
that referenced
this pull request
Mar 23, 2023
using the following patch: cpp-netlib/cpp-netlib#878 to update support for new boost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_io_service()was removed in Boost 1.70.I made a pull request using the alternative
get_executor().context()