Option to create a resource without overwriting existing records #37

Activity

1. woop commented on Jan 4, 2019

   

   woop

   on Jan 4, 2019

   Member

   More actions

   @zhilingc can you highlight the method you are referring to (for extension)?
2. zhilingc commented on Jan 4, 2019

   

   zhilingc

   on Jan 4, 2019

   Last edited by zhilingc

   CollaboratorAuthor

   More actions

   From:

   rpc ApplyFeature(feast.specs.FeatureSpec) returns (CoreServiceTypes.ApplyFeatureResponse) {};
   

   To:

   rpc ApplyFeature(CoreServiceTypes.ApplyFeatureRequest) returns (CoreServiceTypes.ApplyFeatureResponse) {};
   
   message ApplyFeatureRequest {
     feast.specs.FeatureSpec spec = 1;
     bool update = 2;
   }
   

   I'm not sure if i prefer this solution actually.
3. woop commented on Jan 4, 2019

   

   woop

   on Jan 4, 2019

   Member

   More actions

   Well, multiple things:

   • A better abstraction would be ApplyResource or UpdateResource, otherwise we will reinvent this for all resource types. But if we take that logic further...
   • If we eventually intend to move to Kubernetes for managing our resources, then we are basically reinventing the resources management within it. It might be easier to just move all of this into CRDs, and then Feast just becomes a proxy to these requests.
4. woop commented on Sep 1, 2019

   

   woop

   on Sep 1, 2019

   Member

   More actions

   This issue isn't relevant any more due to changes in Feast 0.3.0
5. woop

   closed this as completedon Sep 1, 2019
6. Yanson

   added 2 commits that reference this issue on Jul 29, 2020

   Storage staging to ABFSS (feast-dev#52)

   ...

   14708b8

   Spark historical job + runner (feast-dev#37)

   e862b2e
7. tmihalac

   added a commit that references this issue on Jul 10, 2024

   Merge pull request feast-dev#37 from redhatHameed/services-auth

   ...

   9523266