← 输入框|github.com|刷新
Skip to content

Toggle data stores using flags in feature specifications #38

Closed

Description

@woop

I'm considering whether it is cleaner to have options within feature specifications like useFeatureWarehouse: false to enable or disable a specific type of storage option (serving, warehouse).

Thoughts?

Related to: #5

Activity

  1. tims commented on Jan 6, 2019

    @tims
    Contributor

    This would help override and disable default stores. So I think this is nice.

  2. woop commented on Jan 7, 2019

    @woop
    MemberAuthor

    This would help override and disable default stores. So I think this is nice.

    Great. This is a classic good first issue, haha.

    PR #39

    How is this PR related?

  3. tims commented on Jan 11, 2019

    @tims
    Contributor

    Ah oops.. it's not. I removed my comment.. but it's still linked. ah well.

  4. tims commented on Apr 12, 2019

    @tims
    Contributor

    closing, wont fix, as we believe it would make more sense to configure stores with which features belong to them (in a future where we can deploy multiple serving stores with overlapping feature sets), than to configure the features.

  5. added a commit that references this issue on Jul 29, 2020
  6. added a commit that references this issue on Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions