← 输入框|github.com|刷新
Skip to content

Feast create empty online table when FeatureView attribute online=False #4616

Closed

Description

@SuperBo

Expected Behavior

Feast shouldn't create any DynamoDB table when I defined FeatureView with online=False.

Current Behavior

Feast creates empty DynamoDB table when I defined FeatureView with online=False.

Steps to reproduce

Define a feature store like this

project: example_feature_sotre

provider: aws

offline_store:
  type: spark
  spark_conf: {}

online_store:
  type: dynamodb
  region: us-east-1

entity_key_serialization_version: 2

Feature view def

feature_view = FeatureView(
    name="abc_details_monthly",
    entities=[user_id],
    online=False,
    source=SparkSource(
      table="shcema.abc_details_monthly",
      name="abc_details_monthly",
      timestamp_field="event_date",,
      ttl=datetime.timedelta(days=27),
    # Schema definition
    schema=[
        Field(
            name="feature_1_1d",
            dtype=types.Int32,
            description=""
        )
    ]
)

Specifications

  • Version: 0.40.1
  • Platform: Linux
  • Subsystem:

Possible Solution

Should distinguish list tables to keep of online store and offline store in this file.

Activity

  1. franciscojavierarceo commented on Oct 11, 2024

    @franciscojavierarceo
    Member

    Yeah, agree wasted space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions