Repository navigation
docs: Clarify the initial incremental materialization window - #6888
Merged
ntkathole merged 1 commit intoSep 29, 2026
Merged
Conversation
Signed-off-by: chloe <823083779@qq.com>
ntkathole
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The CLI reference says the first incremental materialization starts at the beginning of time. For regular (non-on-demand) feature views, the implementation uses the current time minus the feature view TTL, falls back to 52 weeks for a zero TTL, and requires a previous materialization when the TTL is unset.
Update the CLI reference and quickstart to describe this initial window and distinguish current time from the supplied end timestamp. This is a documentation-only change.
Which issue(s) this PR fixes:
No linked issue.
Checks
git commit -s)Testing Strategy
Compared both descriptions with
FeatureStore.materialize_incrementaland its CLI caller at base revision213a130c333bdf6ae47b9d8178c7d2c6aff9f396. A focused documentation/source consistency check fails before the edits and passes afterward.git diff --checkpasses. Runtime tests and a full documentation build were not run.Misc
Checked the related changes in #4734 and #6481: the former introduced the earlier quickstart wording; the latter clarifies historical retrieval TTL versus online-store expiration. This PR specifically addresses the initial incremental materialization window.