Repository navigation
feat: Make Milvus index and search params configurable - #6917
Merged
ntkathole merged 1 commit intoOct 1, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6917 +/- ##
==========================================
+ Coverage 48.50% 48.52% +0.01%
==========================================
Files 427 427
Lines 53755 53774 +19
Branches 7827 7832 +5
==========================================
+ Hits 26076 26092 +16
- Misses 25813 25816 +3
Partials 1866 1866
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
force-pushed
the
feat/milvus-index-search-params
branch
from
October 1, 2026 09:43
fe65208 to
37bbcb9
Compare
Search params were hard-coded to {"nprobe": 10} and index params to
{"nlist": nlist}. index_type: AUTOINDEX failed on Milvus servers and
Zilliz Cloud with "only metric type can be passed when use AutoIndex",
because nlist and the collection name were sent as index params.
Adds optional index_params and search_params config fields that are
passed through to Milvus. When unset, the previous defaults are kept,
except that AUTOINDEX gets no params. The collection name is no longer
passed as an index param. AUTOINDEX can now be tuned with the level
search param.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Hearne <simon.hearne@gmail.com>
ntkathole
force-pushed
the
feat/milvus-index-search-params
branch
from
October 1, 2026 12:34
37bbcb9 to
c48b65d
Compare
This was referenced Oct 1, 2026
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Milvus search params were hard-coded to
{"nprobe": 10}and index params to{"nlist": nlist}.index_type: AUTOINDEX(the only option on Zilliz Cloud / managed Milvus) failed withonly metric type can be passed when use AutoIndex, for two reasons:nlistwas always sent, andcollection_namewas passed toIndexParams.add_index, which treats unknown kwargs as index params.index_paramsandsearch_paramsdicts are passed through to Milvus.collection_nameis no longer passed toadd_index.search_params: {level: N}.Which issue(s) this PR fixes:
N/A
Checks
git commit -s)Testing Strategy
Unit tests
Integration tests
Manual tests
Testing is not required for this change
Unit (mocked client): default params unchanged for IVF_FLAT; AUTOINDEX sends only the metric;
HNSW
index_params/search_paramspass through.Unit (Milvus Lite): AUTOINDEX +
levelsearch round trip.Server: AUTOINDEX collection is created and searchable with
level: 2.Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in
sdk/python/tests/integration/online_store/test_milvus_remote.pyare markedintegrationand skip unlessZILLIZ_URIandZILLIZ_TOKENare set; they passed against a local Milvus 2.6.0 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.Misc
Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882 and #6895.