Repository navigation
fix: Pull the MinIO test image from pgsty/minio - #6919
Merged
Merged
Conversation
quay.io/minio/minio and docker.io/minio/minio no longer allow anonymous pulls, so every test that starts a MinIO container fails at setup with "unauthorized: access to the requested resource is not authorized". Switch the test fixtures to pgsty/minio:RELEASE.2026-08-04T00-00-00Z, a multi-arch build of the open-source MinIO server from PGSTY's community-maintained fork. It keeps the same entrypoint, MINIO_ROOT_* variables and health endpoint, so testcontainers' MinioContainer works unchanged. Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6919 +/- ##
=======================================
Coverage 48.50% 48.50%
=======================================
Files 427 427
Lines 53755 53755
Branches 7827 7827
=======================================
Hits 26076 26076
Misses 25813 25813
Partials 1866 1866
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
MinIO no longer allows anonymous pulls from
quay.io/minio/minioordocker.io/minio/minio. Every test that starts a MinIO container now fails at setup:This shows up as 13
[minio_registry]setup errors inintegration-test-registration-localon every PR since about 2026-09-24. Docker Hub stopped serving the images around 2026-09-12, which is why #6838 moved to Quay. Quay then went private as well. MinIO stopped community image releases in October 2025 and archivedminio/minioin December 2025.This PR switches the three test references to
pgsty/minio:RELEASE.2026-08-04T00-00-00Z:server /datacommand,MINIO_ROOT_USER/MINIO_ROOT_PASSWORDvariables and/minio/health/liveendpoint are unchanged, sotestcontainers'MinioContainerneeds no changes.Files changed:
sdk/python/tests/integration/conftest.py(minio_serverfixture)sdk/python/tests/universal/feature_repos/universal/data_sources/file.py(DeltaS3FileSourceCreator,S3FileDataSourceCreator).secrets.baseline(line numbers shifted by the formatting change)Which issue(s) this PR fixes:
Fixes the
[minio_registry]setup errors inintegration-test-registration-local.Checks
git commit -s)Testing Strategy
Ran
tests/integration/registration/test_universal_registry.py -k minio_registrylocally against this image: 11 passed. The other 2,test_modify_feature_views_successandtest_apply_stream_feature_view_success, failed only becausepysparkisn't installed locally. They fail the same way on the sqlite, local and mock-remote registries, and pass in CI.Misc
Other options considered:
cgr.dev/chainguard/miniois free only aslatest.ghcr.io/coollabsio/miniohas had no updates since 2025-10.bitnamilegacy/miniois frozen, and its entrypoint wrapper conflicts withserver /data.