← 输入框|github.com|刷新
Skip to content

fix: Delete saved datasets passed to apply via objects_to_delete - #7045

Open
Vaatsal-source wants to merge 1 commit into
feast-dev:masterfrom
Vaatsal-source:fix/delete-saved-dataset
Open

Vaatsal-source wants to merge 1 commit into
feast-dev:masterfrom
Vaatsal-source:fix/delete-saved-dataset

Conversation

@Vaatsal-source

Copy link
Copy Markdown

What this PR does / why we need it:

FeatureStore.apply(..., objects_to_delete=[...], partial=False) sorts the objects to delete by type, but it had no case for SavedDataset, so saved datasets were silently ignored. Because feast delete <name> deletes through apply(), the CLI printed Deleted SavedDataset <name> while the dataset stayed in the registry.

This PR collects SavedDataset objects from objects_to_delete and removes them with the existing registry.delete_saved_dataset(...), following the same pattern used for validation references. delete_saved_dataset already exists on all registry backends, so no registry changes are needed.

Which issue(s) this PR fixes:

Fixes #7044

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Added test_apply_delete_saved_dataset in test_local_feature_store.py. It registers a saved dataset, deletes it via apply(objects=[], objects_to_delete=[saved_dataset], partial=False), and asserts it is gone. The test fails without the fix.

Manually verified with a local repo that feast delete <saved_dataset> now removes the saved dataset from the registry.

Misc

No docs change needed: the feast delete reference already lists saved datasets as supported.

FeatureStore.apply() ignored SavedDataset objects in objects_to_delete, so 'feast delete <saved_dataset>' reported success without removing the dataset from the registry.

Signed-off-by: Vaatsalya Srivastava <vaatsalyasrivastava_ee_25a19036@dtu.ac.in>
@Vaatsal-source
Vaatsal-source requested a review from a team as a code owner October 19, 2026 08:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feast delete reports success for a SavedDataset but does not remove it from the registry

2 participants