Repository navigation
fix: Delete saved datasets passed to apply via objects_to_delete - #7045
Open
Vaatsal-source wants to merge 1 commit into
Open
Vaatsal-source wants to merge 1 commit into
Vaatsal-source wants to merge 1 commit into
Conversation
FeatureStore.apply() ignored SavedDataset objects in objects_to_delete, so 'feast delete <saved_dataset>' reported success without removing the dataset from the registry. Signed-off-by: Vaatsalya Srivastava <vaatsalyasrivastava_ee_25a19036@dtu.ac.in>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FeatureStore.apply(..., objects_to_delete=[...], partial=False)sorts the objects to delete by type, but it had no case forSavedDataset, so saved datasets were silently ignored. Becausefeast delete <name>deletes throughapply(), the CLI printedDeleted SavedDataset <name>while the dataset stayed in the registry.This PR collects
SavedDatasetobjects fromobjects_to_deleteand removes them with the existingregistry.delete_saved_dataset(...), following the same pattern used for validation references.delete_saved_datasetalready exists on all registry backends, so no registry changes are needed.Which issue(s) this PR fixes:
Fixes #7044
Checks
git commit -s)Testing Strategy
Added
test_apply_delete_saved_datasetintest_local_feature_store.py. It registers a saved dataset, deletes it viaapply(objects=[], objects_to_delete=[saved_dataset], partial=False), and asserts it is gone. The test fails without the fix.Manually verified with a local repo that
feast delete <saved_dataset>now removes the saved dataset from the registry.Misc
No docs change needed: the
feast deletereference already lists saved datasets as supported.