Repository navigation
Conversation
…ne_write_batch Signed-off-by: Mrun25 <165297479+Mrun25@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
SparkOfflineStore.offline_write_batchonly looked atfile_formatfor path-basedSparkSources. A source configured withtable_format(for example Delta) and nofile_formatwas read and written withformat(None).The existing-data read now goes through
SparkSource._load_dataframe_from_path, the same code the retrieval path uses. The write usestable_format.format_typeand its properties whentable_formatis set, and falls back tofile_formatotherwise, so sources without a table format behave as before.Testing
Added
test_spark_offline_write_batch.pycovering file_format only, table_format only (with options), and table_format taking precedence. The new tests fail without the change and pass with it.Fixes #6955