Repository navigation
Conversation
The feature-monitoring UI picked the baseline metrics row as the newest window because the baseline is saved with metric_date = today. That made the monitoring tab land on the baseline instead of real data, listed 'baseline' as a granularity in the detail view, mixed window lengths in the time series, and compared mismatched histogram bins (raw counts on different bin edges, with a TypeError when the baseline was categorical and the window numeric). - FeatureMonitoringTab: select the latest non-baseline window row via selectLatestWindowMetric - FeatureMetricsDetail: filter baseline rows out of the granularity list and render each granularity's time series separately - HistogramChart: rebin numeric baselines onto the window's bin edges, compare densities instead of raw counts, and guard non-numeric baselines - add histogramUtils with unit tests (9 passing) Fixes feast-dev#7054 Signed-off-by: Mrun25 <165297479+Mrun25@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
4 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature-monitoring UI treats the baseline metrics row as the newest window because the baseline is saved with metric_date = today (monitoring_service.py:182,:462, granularity "baseline"). On the current master this means:
Reproduced against master (e304a84) with the real DuckDB monitoring path (MonitoringService._save_computed_metrics + get_feature_metrics), no feast server needed.
Fix:
Tests: 9 new jest tests pass; full UI suite unchanged vs master (3 pre-existing local failures from un-generated protos; CI runs generate-protos); tsc and eslint clean on changed files.
Fixes #7054