Repository navigation
Conversation
When a registry lookup references a feature view name that does not exist in the project (for example the project-prefixed online store table name), FeatureViewNotFoundException now suggests close matches from the registry so the mistake is self-correcting. Fixes feast-dev#5606 Signed-off-by: Mrun25 <165297479+Mrun25@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a registry lookup references a feature view name that does not exist in the project,
FeatureViewNotFoundExceptiononly says the name was not found. A common way to hit this is copying the project-prefixed online store table name (online tables are named{project}_{feature_view}) into a feature reference, as in #5606 - the error then reads like a registry or materialization bug even though the feature view exists under its real name.With this change the exception suggests close matches from the registry when there are any:
The suggestion is computed in
proto_registry_utils.get_any_feature_view(the lookup path behindget_online_features) withdifflib.get_close_matchesover all feature-view collections in the project; when nothing is close, the message is unchanged.Which issue(s) this PR fixes:
Fixes #5606
Testing
tests/unit/infra/registry/test_proto_registry_utils.py